tree 5ddbe36673e1f851ea1bf259801ec1f635b281b1
parent bc9a6417c047ca110f4d5e5d6c354fe42b7091e3
author Ben Chan <benchan@chromium.org> 1489528982 -0700
committer chrome-bot <chrome-bot@chromium.org> 1489699431 -0700

shill: populate a missing error in Manager::ConfigureServiceForProfile

When Manager::ConfigureServiceForProfile() creates and configures a
temporary service, it decides not to return the unusable service but
forgets to populate an error, which will eventually trigger a assertion
in ChromeosManagerDBusAdaptor::ConfigureServiceForProfile(). This CL
ensures that Manager::ConfigureServiceForProfile populates an error
under such condition.

BUG=chromium:701315
TEST=Run unit tests.

Change-Id: Id990de604982cffcc68dff2899ac9859935625bb
Reviewed-on: https://chromium-review.googlesource.com/455256
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>