tree 405b64a7e8cffb643114ca53a4ae2c8c5089b4a8
parent 59a3305626d164a56b5c5753bde65732e2ce2c81
author Kevin Cernekee <cernekee@chromium.org> 1495161497 -0700
committer chrome-bot <chrome-bot@chromium.org> 1495227456 -0700

shill: Remove workaround for old c-ares resolver bug

Per https://github.com/c-ares/c-ares/pull/11 the c-ares library used
to require callers to specify IPv6 DNS server addresses in the format:

    2001:4860:4860::6464:53
    (the actual host is [2001:4860:4860::6464])

shill did this, but then the API changed.  As a result, c-ares
now parses the above string as a literal IPv6 host address (without a
port), causing portal detection to time out because it's using incorrect
DNS server IPs.  On a pure IPv6 network this causes portal detection to
keep rerunning continuously.

Fix this by reverting the workaround.

BUG=chromium:722809
TEST=manually connect to a NAT64 network
TEST=run unit tests

Change-Id: I64b429255274ca45d4fe1332e4eb98b8a4f59c5e
Reviewed-on: https://chromium-review.googlesource.com/509268
Commit-Ready: Kevin Cernekee <cernekee@chromium.org>
Tested-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>