commit b916efce93f92226c6ec20ebfc38f04593155a52
author Tom Sepez <tsepez@google.com> Thu Dec 04 06:19:11 2025
committer Copybara-Service <copybara-worker@google.com> Thu Dec 04 06:24:14 2025
tree e534922d8c20a750fe2ac2c52d22e7fdbfea7f1b
parent 5a3652668e168294d5ac05a6abaab504ee960127

Avoid size_t to int casting in EXPECT/ASSERT/CHECK macros

Using unsigned literals avoids the need for such casts, and reduces the
number of potentially unsafe casts to be investigated down the road.

NO_IFTTT=functionality unchanged.

Change-Id: I520771eebb5f62913bca5a35c3ae2b031f33a451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7218814
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1553821}
NOKEYCHECK=True
GitOrigin-RevId: 1e21e332da18d54eddbb39fbdd080ca07de7241e

json/json_value_converter_unittest.cc

diff --git a/json/json_value_converter_unittest.cc b/json/json_value_converter_unittest.cc
index a66abb9..b21db19 100644
--- a/json/json_value_converter_unittest.cc
+++ b/json/json_value_converter_unittest.cc
@@ -120,8 +120,8 @@
   EXPECT_EQ("bar", message.bar);
   EXPECT_TRUE(message.baz);
   EXPECT_EQ(SimpleMessage::FOO, message.simple_enum);
-  EXPECT_EQ(2, static_cast<int>(message.ints.size()));
-  ASSERT_EQ(2U, message.string_values.size());
+  EXPECT_EQ(2u, message.ints.size());
+  ASSERT_EQ(2u, message.string_values.size());
   EXPECT_EQ("value_1", *message.string_values[0]);
   EXPECT_EQ("value_2", *message.string_values[1]);
   EXPECT_EQ(1, *(message.ints[0]));
@@ -169,7 +169,7 @@
   EXPECT_EQ("value_1", *message.child.string_values[0]);
   EXPECT_EQ("value_2", *message.child.string_values[1]);
 
-  EXPECT_EQ(2, static_cast<int>(message.children.size()));
+  EXPECT_EQ(2u, message.children.size());
   const SimpleMessage* first_child = message.children[0].get();
   ASSERT_TRUE(first_child);
   EXPECT_EQ(2, first_child->foo);
@@ -225,7 +225,7 @@
 
   EXPECT_EQ(1, message.foo);
   EXPECT_TRUE(message.baz);
-  EXPECT_EQ(2, static_cast<int>(message.ints.size()));
+  EXPECT_EQ(2u, message.ints.size());
   EXPECT_EQ(1, *(message.ints[0]));
   EXPECT_EQ(2, *(message.ints[1]));
 }