commit | 9301585daed8c2f30be2157a2f883044dce30b1f | [log] [tgz] |
---|---|---|
author | Alison Gale <agale@chromium.org> | Mon Apr 22 23:34:28 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Mon Apr 22 23:42:56 2024 |
tree | e7b30d5539eec891ed69eef1defd77c367ecff16 | |
parent | e04dba541b6dd1232977db3b8103782a0a6884d9 [diff] |
Migrate TODOs referencing old crbug IDs to the new issue tracker IDs The canonical bug format is TODO(crbug.com/<id>). TODOs of the following forms will all be migrated to the new format: - TODO(crbug.com/<old id>) - TODO(https://crbug.com/<old id>) - TODO(crbug/<old id>) - TODO(crbug/monorail/<old id>) - TODO(<old id>) - TODO(issues.chromium.org/<old id>) - TODO(https://issues.chromium.org/<old id>) - TODO(https://issues.chromium.org/u/1/issues/<old id>) - TODO(bugs.chromium.org/<old id>) Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues. See go/crbug-todo-migration for details. #crbug-todo-migration Bug: b/321899722 Change-Id: Ib028de8bb63c99e5a81d90e24e422cf88061ad05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469583 Owners-Override: Alison Gale <agale@chromium.org> Reviewed-by: Darryl James <dljames@chromium.org> Commit-Queue: Alison Gale <agale@chromium.org> Cr-Commit-Position: refs/heads/main@{#1290952} NOKEYCHECK=True GitOrigin-RevId: 923a33e9d5e24f4fb64f40dd2ffc182b2de93b0f
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/41240413): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.