Google Git
Sign in
chromium / chromium / src / third_party / WebKit / Source / platform / v8_inspector / 8332685eacddb62fe8b6a07f94cd1803443f2750
commit8332685eacddb62fe8b6a07f94cd1803443f2750[log] [tgz]
authordgozman <dgozman@chromium.org>Fri Aug 26 22:54:30 2016
committerCommit bot <commit-bot@chromium.org>Fri Aug 26 22:58:44 2016
tree2703571cb0a53bf50d47b7614a05cc2360567430
parentfc4a3116aa2f91b4acae74598c3a0305511b2e2e [diff]
[DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Using StringView for inbound parameters and StringBuffer for outbound helps to avoid copies in important places (mostly when passing large protocol messages around).

This opens possibility to:
- use WTF::String in core/inspector instead of String16;
- make String16 an alias to std::basic_string<uint16_t> to leverage all existing
optimizations.

One possible optimization is to migrate search utility (in V8StringUtil) to
StringView and avoid any copies of content there.

BUG=637032

Review-Url: https://codereview.chromium.org/2260233002
Cr-Original-Commit-Position: refs/heads/master@{#414846}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 101f402f95f5a67df948347edc4dce050ce482c7
27 files changed
tree: 2703571cb0a53bf50d47b7614a05cc2360567430
  1. build/
  2. public/
  3. Atomics.h
  4. debugger_script_externs.js
  5. DebuggerScript.js
  6. injected_script_externs.js
  7. InjectedScript.cpp
  8. InjectedScript.h
  9. InjectedScriptNative.cpp
  10. InjectedScriptNative.h
  11. InjectedScriptSource.js
  12. InspectedContext.cpp
  13. InspectedContext.h
  14. inspector_protocol_config.json
  15. inspector_protocol_config_stl.json
  16. JavaScriptCallFrame.cpp
  17. JavaScriptCallFrame.h
  18. js_protocol-1.2.json
  19. js_protocol.json
  20. OWNERS
  21. PlatformSTL.h
  22. PlatformWTF.h
  23. RemoteObjectId.cpp
  24. RemoteObjectId.h
  25. ScriptBreakpoint.h
  26. String16STL.cpp
  27. String16STL.h
  28. String16WTF.h
  29. v8_inspector.gyp
  30. V8Compat.h
  31. V8Console.cpp
  32. V8Console.h
  33. V8ConsoleAgentImpl.cpp
  34. V8ConsoleAgentImpl.h
  35. V8ConsoleMessage.cpp
  36. V8ConsoleMessage.h
  37. V8Debugger.cpp
  38. V8Debugger.h
  39. V8DebuggerAgentImpl.cpp
  40. V8DebuggerAgentImpl.h
  41. V8DebuggerScript.cpp
  42. V8DebuggerScript.h
  43. V8FunctionCall.cpp
  44. V8FunctionCall.h
  45. V8HeapProfilerAgentImpl.cpp
  46. V8HeapProfilerAgentImpl.h
  47. V8InjectedScriptHost.cpp
  48. V8InjectedScriptHost.h
  49. V8InspectorImpl.cpp
  50. V8InspectorImpl.h
  51. V8InspectorSessionImpl.cpp
  52. V8InspectorSessionImpl.h
  53. V8InternalValueType.cpp
  54. V8InternalValueType.h
  55. V8ProfilerAgentImpl.cpp
  56. V8ProfilerAgentImpl.h
  57. V8Regex.cpp
  58. V8Regex.h
  59. V8RuntimeAgentImpl.cpp
  60. V8RuntimeAgentImpl.h
  61. V8SchemaAgentImpl.cpp
  62. V8SchemaAgentImpl.h
  63. V8StackTraceImpl.cpp
  64. V8StackTraceImpl.h
  65. V8StringUtil.cpp
  66. V8StringUtil.h
  67. V8ValueCopier.cpp
  68. V8ValueCopier.h