ADHD: Simplify FIFO use & address latent issues

Details

  o FIFO_DEFINE incorrectly defined the fifo variable as 'workfifo'.

  o fifo_add_item() gets multiply defined when new FIFOs are added.
    Change the naming so that the fifo name is part of the function
    signature.  Made FIFO_ADD_ITEM() to create the proper function
    name.  Updated FIFO_DEFINE() to also create the proper name for
    the 'add' function.

  o Internalized __FIFO_DESCRIPTOR_ADDRESS().  This is no longer
    needed when adding elements to the FIFO; it's now handled in
    FIFO_ADD_ITEM().

Testing

  Built ADHD on tegra2_aebl, x86-mario.

  Verified gavd still functions properly on tegra2_aebl.

BUG=chromium-os:19558
TEST=See above.

Change-Id: Iae4e2fa4af3f61a739e87be4bb8def9d937977db
Signed-off-by: Taylor Hutt <thutt@chromium.org>
3 files changed