| commit | 6a16d9c8cf5b54be32237e2e2637c8c4685ff2d2 | [log] [tgz] |
|---|---|---|
| author | Lukasz Majczak <lmajczak@google.com> | Thu Aug 31 08:38:44 2023 |
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 21 09:09:37 2023 |
| tree | 84d392c1a2571894bed09717be7fad3f580bacbb | |
| parent | 01d4fc123b3631b1628bc86f9271e278b0e34634 [diff] |
daisydog: store daisydog output and ret value Current approach puts daisydog check command output only to syslog skipping stderr which in turn leads to the situation that watchdog resets are never reported to metrics daemon. Fix it by storing daisydog output and return value in separate variables for check and logging purpouse. BUG=b:294439578 TEST=Check if logs appear in syslog Change-Id: Ic25090158d982860e1fcf63225c87d6cadceacfc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/daisydog/+/4831511 Commit-Queue: Grant Grundler <grundler@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> Tested-by: Lukasz Majczak <lmajczak@google.com>
GPL Code is copied with explicit permission from Daniel Widyanto:
http://embeddedfreak.wordpress.com/2010/08/23/howto-use-linux-watchdog/
The project name is based on Samsung's “daisy” reference board design and I liked this quote from the daisy dog FAQ:
Daisy Dogs are not persnickety little ankle biters
When this daisydog doesn't run, the machine should reset. :)
An alternative code to start with would have been:
https://dev.openwrt.org/ticket/2270
The watchdog project is alot more complicated than what the Chromium OS project needs.