| commit | cd82b41fefe3dbf7fd0bca93aa7fad86938d483f | [log] [tgz] |
|---|---|---|
| author | Lukasz Majczak <lmajczak@google.com> | Thu Aug 31 08:38:44 2023 |
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Sep 23 01:08:29 2023 |
| tree | c7bf2d6fe1f02183195ac0c5c5412e948badcd85 | |
| parent | 87ad5bbfc716199616c2a07ff735dcb7dc541bee [diff] |
daisydog: store daisydog output and ret value (take 2) Current approach puts daisydog check command output only to syslog skipping stderr which in turn leads to the situation that watchdog resets are never reported to metrics daemon. Fix it by storing daisydog output and return value in separate variables for check and logging purpouse. BUG=b:294439578 TEST=Check if logs appear in syslog Change-Id: Id66863482a4e447188fcc6bec1f4614493b1b308 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/daisydog/+/4886709 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> Tested-by: Lukasz Majczak <lmajczak@google.com> Commit-Queue: Grant Grundler <grundler@chromium.org>
GPL Code is copied with explicit permission from Daniel Widyanto:
http://embeddedfreak.wordpress.com/2010/08/23/howto-use-linux-watchdog/
The project name is based on Samsung's “daisy” reference board design and I liked this quote from the daisy dog FAQ:
Daisy Dogs are not persnickety little ankle biters
When this daisydog doesn't run, the machine should reset. :)
An alternative code to start with would have been:
https://dev.openwrt.org/ticket/2270
The watchdog project is alot more complicated than what the Chromium OS project needs.