BACKPORT: Input: xpad - fix oops when attaching an unknown Xbox One gamepad
Xbox One controllers have multiple interfaces which all have the
same class, subclass, and protocol. One of the these interfaces
has only a single endpoint. When Xpad attempts to bind to this
interface, it causes an oops when trying initialize the output URB
by trying to access the second endpoint's descriptor.
This situation was avoided for known Xbox One devices by checking
the XTYPE constant associated with the VID and PID tuple. However,
this breaks when new or previously unknown Xbox One controllers
are attached to the system.
This change addresses the problem by deriving the XTYPE for Xbox
One controllers based on the interface protocol before checking
the interface number.
Fixes: 1a48ff81b391 ("Input: xpad - add support for Xbox One controllers")
Signed-off-by: Cameron Gutman <aicommander@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Conflicts:
drivers/input/joystick/xpad.c
- context changes.
BUG=chromium:876128
TEST=Build and boot
(cherry picked from commit c7f1429389ec1aa25e042bb13451385fbb596f8c)
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Change-Id: Id780efd3d7bb392d4b00d37dbcf48f4f7afe5954
Reviewed-on: https://chromium-review.googlesource.com/1279332
Reviewed-by: Guenter Roeck <groeck@chromium.org>
1 file changed
