commit | 83233e4b9b7b5b947ddd60cf97a1013c6b7375ae | [log] [tgz] |
---|---|---|
author | Sangwhan Moon <sxm@google.com> | Tue Sep 21 15:41:31 2021 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Sep 23 08:41:38 2021 |
tree | a4694dc48dde67f383a41fb69d84c4873948f6a6 | |
parent | 2338900b840dd21c41a76038e6ba9d743e82109b [diff] |
CHROMIUM: fuse: Set SB_NOSEC for virtiofs Currently when caching is enabled the fuse driver sends a getxattr request for every write request to see if the security.capability xattr is set. This adds a significant amount of latency to every write operation. However, the kernel provides a flag that can be set on the file system superblock (SB_NOSEC) that effectively allows the kernel to cache the value of the xattr. This is disabled by default for fuse. Enable SB_NOSEC for virtiofs. This requires making some assumptions that we know are true for virtiofs but may not be true for generic fuse servers. The proper fix is being worked on upstream (the latest patch series is [1]) so this is just a temporary solution until the upstream fix can be backported. BUG=b:163383485 TEST=`fio --ioengine=libaio --direct=1 --name=test --filename=$FILENAME --bs=4k --iodepth=64 --size=4G --readwrite=randwrite` Without this change the fio benchmark gives a write bandwidth of 26 MiB/s. With this change the fio benchmark gives a write bandwidth of 194 MiB/s, which is a very significant improvement. [1]: https://lore.kernel.org/linux-fsdevel/20201009181512.65496-1-vgoyal@redhat.com/ Change-Id: I074b009c122a3abeccdb7e23beae284b6ec3d3ec Signed-off-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2486004 Reviewed-by: Suleiman Souhlal <suleiman@chromium.org> Reviewed-by: Lepton Wu <lepton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3172894 Reviewed-by: Hikaru Nishida <hikalium@chromium.org> Tested-by: Sangwhan Moon <sxm@google.com> Commit-Queue: Sangwhan Moon <sxm@google.com>
BEST: Make all of your changes to upstream Linux. If appropriate, backport to the stable releases. These patches will be merged automatically in the corresponding common kernels. If the patch is already in upstream Linux, post a backport of the patch that conforms to the patch requirements below.
EXPORT_SYMBOL_GPL()
require an in-tree modular driver that uses the symbol -- so include the new driver or changes to an existing driver in the same patchset as the export.LESS GOOD: Develop your patches out-of-tree (from an upstream Linux point-of-view). Unless these are fixing an Android-specific bug, these are very unlikely to be accepted unless they have been coordinated with kernel-team@android.com. If you want to proceed, post a patch that conforms to the patch requirements below.
script/checkpatch.pl
UPSTREAM:
, BACKPORT:
, FROMGIT:
, FROMLIST:
, or ANDROID:
.Change-Id:
tag (see https://gerrit-review.googlesource.com/Documentation/user-changeid.html)Bug:
tag.Signed-off-by:
tag by the author and the submitterAdditional requirements are listed below based on patch type
UPSTREAM:
, BACKPORT:
UPSTREAM:
.(cherry picked from commit ...)
lineimportant patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
UPSTREAM: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 (cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1) Signed-off-by: Joe Smith <joe.smith@foo.org>
BACKPORT:
instead of UPSTREAM:
.UPSTREAM:
(cherry picked from commit ...)
lineBACKPORT: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 (cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1) [joe: Resolved minor conflict in drivers/foo/bar.c ] Signed-off-by: Joe Smith <joe.smith@foo.org>
FROMGIT:
, FROMLIST:
,FROMGIT:
(cherry picked from commit <sha1> <repo> <branch>)
. This must be a stable maintainer branch (not rebased, so don't use linux-next
for example).BACKPORT: FROMGIT:
important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
FROMGIT: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 (cherry picked from commit 878a2fd9de10b03d11d2f622250285c7e63deace https://git.kernel.org/pub/scm/linux/kernel/git/foo/bar.git test-branch) Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
FROMLIST:
Link:
tag with a link to the submittal on lore.kernel.orgBug:
tag with the Android bug (required for patches not accepted into a maintainer tree)BACKPORT: FROMLIST:
FROMLIST: important patch from upstream This is the detailed description of the important patch Signed-off-by: Fred Jones <fred.jones@foo.org> Bug: 135791357 Link: https://lore.kernel.org/lkml/20190619171517.GA17557@someone.com/ Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
ANDROID:
ANDROID:
Fixes:
tag that cites the patch with the bugANDROID: fix android-specific bug in foobar.c This is the detailed description of the important fix Fixes: 1234abcd2468 ("foobar: add cool feature") Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01 Signed-off-by: Joe Smith <joe.smith@foo.org>
ANDROID:
Bug:
tag with the Android bug (required for android-specific features)