upstart: Remove all __attribute__(malloc) usage
This is very likely incorrect in most or all of its uses because the
marked functions take a parent object that acquires a reference to the
new child, and the "malloc" attribute promises that no such aliases
exist.
Further, there seems to be no precise explanation of what clang
assumes in the presence of this attribute, nor any tool that can check
these assumptions, so there's no way to be confident in any usage
anywhere.
The only justification given for this in the documentation are
unspecified optimisations, but there's no indication of the
performance impact, and given the above they may be incorrect anyway.
BUG=b:232122437
TEST=FEATURES=test emerge-eve upstart
Change-Id: Ibe8749c80f73bfdbce4bf0c7ba2d189b95d264d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/upstart/+/3643616
Reviewed-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
13 files changed
