tree 24fb80f961eacb64cee9e29c07189a899ed400ae
parent fbe1ed616fd91aae781f7cfbce027d91114f78e5
author Alon Zakai <azakai@google.com> 1683656238 -0700
committer GitHub <noreply@github.com> 1683656238 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJkWo4uCRBK7hj4Ov3rIwAAxtwIAAI2esdbInlyjlW23M2CMc5Y
 ooktU3ysnw8DEDldkWnnCXN71iitR7Jr4H+pna2+FqG6fzICfYzj5WEUfN59v07a
 w/i5OpYJlGUwDbk3p6Ao9x5geNaEsCUkTgDvK0SiG0+vYCTzlXuJMNm2OJ8beWC5
 cwSZ12GpcUYlndYyolQKbf8f/MWIoCqaxaacBlifDbYQqT/S8QG4ay3frYRt+F5s
 4DUybbSyGJpbXvCdyADRBXcfeKvXk93ab/hL57HySqOjnXnsEX1wJYL7oR2V9Fcv
 zynRlqzDpo5P4JRJ7S8RsVX+1wiVQMyEFLNbNvXXpqYeikywr+b969gpwCtoKzM=
 =w2bU
 -----END PGP SIGNATURE-----
 

Remove TypeUpdater in Vacuum and always ReFinalize (#5707)

TypeUpdater::remove must be called after removing a thing from the
tree. If not, then we can get confused by something like this:

(block $b
  (br $b)
)

If we first call TypeUpdater::remove then we see that the block's only
br is going away, so it becomes unreachable. But when we then remove
the br then the block should have type none. Removing the br first
from the IR, and then calling TypeUpdater::remove, is the safe way to do it.

However, changing that order in Vacuum is not trivial. After looking into
this, I realized that it is just simpler to remove TypeUpdater entirely.
Instead, we can ReFinalize at the end unconditionally. This has the downside
that we do not propagate type updates "as we go", but that should be very
rare.

Another downside is that TypeUpdater tracks the number of brs, which
can help remove code like in the one test that regresses here (see comment
there). But I'm not sure that removal was valid - Vacuum should not really be
doing it, and it looks like its related to this bug actually. Instead, we have a
dedicated pass for removing unused brs - RemoveUnusedBrs - so leave
things for it.

This PR's benefit, aside from now handling the fuzz testcase, is that it makes
the code simpler and faster. I see a 10-25% speedup on the Vacuum pass on
various binaries I tested on. (Vacuum is one of our faster passes anyhow,
though, so the runtime of -O1 is not much improved.)

Another minor benefit might be that running ReFinalize more often can
propagate type info more quickly, thanks to #5704 etc. But that is probably
very minor.