| commit | f9d75bb32a29d2cfa6802aaf9c69b133d1d1fb4c | [log] [tgz] |
|---|---|---|
| author | Seth Koehler <sethkoehler@google.com> | Tue Dec 19 18:59:33 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 20 15:41:59 2017 |
| tree | 3dfe078f75830457b9c8a999fcd7d952ad22225d | |
| parent | 79070b7c2fbf1fdb038b72a7e810ec4252bbff82 [diff] |
Fix race condition (COMPLETED/BOT_DIED) in task_runner. Per b/69462084 and a TODO comment in this file, a race condition exists when an external process polls task status that fails with BOT_DIED (there's a short window in which the task will be marked as COMPLETED before being updated to BOT_DIED). This change sends the task-update without the exit code (to prevent the COMPLETED status from being set), and then sends a task_error message. The default must_signal_internal_failure is also changed to provide a default error in case run_isolated fails. TESTED=Ran unit tests in task_runner_test and they pass. Any other tests? Change-Id: I1db3e15ccbdac3da9181b273681180211b07841c Reviewed-on: https://chromium-review.googlesource.com/834397 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/infra/luci/luci-py Cr-Mirrored-Commit: 0b027452e658080df1f174c403946914443d2aa6
This is the Python Client code for LUCI. It's part of the main python repo, and is also mirrored into a standalone client-py repo.
This project is licensed under Apache v2.0 license. See LICENSE for details.