| commit | 45ff0824132907fcd34fa494b9aac0ffc9fd97b0 | [log] [tgz] |
|---|---|---|
| author | Yu Han <yuzhehan@chromium.org> | Wed May 27 21:15:38 2020 |
| committer | Chromium WPT Sync <blink-w3c-test-autoroller@chromium.org> | Wed May 27 21:15:38 2020 |
| tree | a30254da126c9ee55723b4b77ac525b29c273053 | |
| parent | 6a76a185f913e3c027e369a567a276c62a8646d6 [diff] |
Fixes input stepUp() and stepDown with no value set. Prior to this CL,[1], introduced a regression where if no value is set for an input type that supports stepping, calling stepDown() on an input with min > 0 or calling stepUp() on an input with max < 0 doesn't set the input.value to its min or max. The reason is [1] introduces a new logic for handling value, step #10 in [2]. And since we default current value to 0 if not set, the valueBeforeStepping (0) is less than new value,(ex: min == 5). I couldn't find in the spec where it defines this special case. The closest I found is in, [3]: > When the element is suffering from a step mismatch, the user > agent may round the element's value to the nearest number for > which the element would not suffer from a step mismatch. > If there are two such numbers, user agents are encouraged to > pick the one nearest positive infinity. In addition, the behavior prior to [1] for chromium is that the value will be set for the case above. Firefox also handles this case here, [4]. The fix is to keep track if current value is NaN and prevent step #10 if value is NaN. Also, for input-stepup.html test, none of the date types can go negative, so only number type makes sense. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1959631 [2] https://html.spec.whatwg.org/multipage/input.html#dom-input-stepup [3] https://html.spec.whatwg.org/multipage/input.html#number-state [4] https://searchfox.org/mozilla-central/source/dom/html/HTMLInputElement.cpp#1944 Bug:1083870 Change-Id: I60788016f09c5e382fcc58c8c32359fa058de9c6
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!