commit | 7139ebd732fe439de0c3f47040c77e7bf305a929 | [log] [tgz] |
---|---|---|
author | Joonghun Park <pjh0718@gmail.com> | Tue Mar 08 21:49:29 2022 |
committer | Chromium WPT Sync <blink-w3c-test-autoroller@chromium.org> | Tue Mar 08 21:49:29 2022 |
tree | b255e10c9b7b5457b3534ed9b4cca87d48cdc7d3 | |
parent | 1604349cf2443e5f9c8589ed62789cb455932d6e [diff] |
Implement css calc simplification and serialization per spec. The corresponding specs are below. * calc simplification spec: https://drafts.csswg.org/css-values-4/#calc-simplification * calc serialization spec: https://drafts.csswg.org/css-values-4/#calc-serialize CSS calc simplification is a kind of constant folding which evaluates css calculation tree to the extent possible at parse time, so that evaluation at computed/used-value time can be reduced. This CL does: 1) Introduce Negate and Invert nodes in /css and /platform to handle subtraction and division respectively so that we track of only Sum and Product operator, which makes it possible to sort child nodes for simplification. 2) Do bottom-up simplification for the result of CSSMathExpressionNodeParser per the spec above, which sorts child nodes per https://drafts.csswg.org/css-values-4/#sort-a-calculations-children, combines child nodes where possible, and hoists child nodes up to their parents where possible. And simplification always preserves a math function (calc(), clamp(), etc) at the root. This simplification also does unit canonicalization (e.g. all absolute lengths get px units). To make unit conversion more explicit, pass a CSSPrimitiveValue::UnitType into DoubleValue() methods so that it's clear what units the resulting value is in. 3) Serialize per the spec above which fixes bugs with nested parentheses, e.g. calc(20% + 10px + 10em - 10%) should be serialized to calc(10% + 10em + 10px) but was serialized to calc((20% + 10px + 10em) - 10%) before this change. The remaining things to do are as below. 1) Remove CSSMathExpressionOperation::CreateArithmeticOperationSimplified() which is being used only by InterpolableLength. 2) Aligning CSSOM implementation which assumes that the number of basic arithmetic operation's children is 2 with this change. 3) Fix the test regressions occurred by this change. Bug: 1253162 Change-Id: I825a250aaa19ae3589f50172afbe5577141be32b
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!