commit | 774015d2453bba40a25a5a304e6ae1b0ff6174a3 | [log] [tgz] |
---|---|---|
author | Mouffull <dickmouth8340@gmail.com> | Wed May 17 00:52:08 2023 |
committer | Chromium WPT Sync <blink-w3c-test-autoroller@chromium.org> | Wed May 17 00:52:08 2023 |
tree | 21b4c89f340f102c93e3660cf0c2951fe14c582e | |
parent | bbc11e069dcb79d8a3f40b904f25d26451db4c50 [diff] |
Reland "Improve hover triggering functionality to support popover=manual" This reverts commit 922d1329ebb3f0b7ebe164b56c4a4fa14943ed78. Reason for revert: <Slow> Original change's description: > Revert "Improve hover triggering functionality to support popover=manual" > > This reverts commit e4cde2ad20aac0ace162db28090bc421df2e7e76. > > Reason for revert: Compile break: https://ci.chromium.org/ui/p/chromium/builders/ci/lacros64-archive-rel/53380/overview > > Original change's description: > > Improve hover triggering functionality to support popover=manual > > > > This CL primarily adds a much larger hover hiding test, which tests > > all popover types, two invoker types, and all popovertargetaction > > values. In building that, I found a number of cases that weren't > > properly handled, mostly because hover detection was using a version > > of IsNodePopoverDescendant that was fairly manual and old. This > > new version makes better use of a newly-expanded > > FindTopmostRelatedPopover which is able to optionally look at manual > > popovers. In doing this, I also refactored the `inclusive` argument > > into an EnumSet to allow controlling the manual popover behavior > > at the same time. > > > > Bug: 1416284 > > Fixed: 1443372 > > Fixed: 1445580 > > Change-Id: I2370610b4c7517fa635c353f0cfaf6de7b16b3af > > Cq-Do-Not-Cancel-Tryjobs: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4505324 > > Commit-Queue: Mason Freed <masonf@chromium.org> > > Auto-Submit: Mason Freed <masonf@chromium.org> > > Reviewed-by: Joey Arhar <jarhar@chromium.org> > > Commit-Queue: Joey Arhar <jarhar@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1144968} > > Bug: 1416284 > Change-Id: I6ed5ce2f3b7ace980838cf8e0106ecc3a5fb9cc1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4540744 > Owners-Override: Nate Chapin <japhet@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1144983} Bug: 1416284 Change-Id: I9988e1b22405b7c223d32412f795f54b16dfd6b8
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!