| commit | ccbfcbc6ba6b6483d8058e0264bbdf904e8abd75 | [log] [tgz] |
|---|---|---|
| author | Anders Hartvoll Ruud <andruud@chromium.org> | Fri Oct 06 19:43:22 2023 |
| committer | Chromium WPT Sync <blink-w3c-test-autoroller@chromium.org> | Fri Oct 06 19:43:22 2023 |
| tree | 0aabae0ae88d9c8319a7139ba7b11b7d2bb8a39f | |
| parent | 0a366a4aa0d18fcb055a5b75c898cc7ad39aae1a [diff] |
Remove AllowMarkStyleDirtyFromRecalcScope for <img> fallbacks During HTMLImageElement::AdjustStyle, we do something very shady: we poke into the UA shadow and mutate the inline style of some of the elements in there. This causes style to be marked dirty *during* style recalc, which is not a desirable situation. The behavior would normally trigger a DCHECK, but it is currently suppressed with by AllowMarkStyleDirtyFromRecalcScope. Marking style dirty deeper in the current subtree works (sort of), because we'll eventually reach those elements during the current style recalc process anyway, so ultimately the dirtiness is cleared. However, StyleResolver::ResolveStyle can also be called *outside* of style recalc. For example, when producing styles for kFirstLineInherited, we call ResolveStyle during *layout*. In this case, there is no greater style recalc process ongoing, so the dirtiness isn't cleared, and we trigger DCHECKs (Issue 1486128). This CL addresses the problem as follows: - When adjusting the style for the UA shadow host (<img>), we capture the state descendants care about into an inherited object StyleHostData. - Later, when recalculating the style of descendants (inside the shadow), we give the elements an opportunity to produce an "extra" CSSPropertyValueSet which is added into the cascade. This CSSPropertyValueSet can be produced based on the previously captured StyleHostData. Fixed: 953707, 1486128 Change-Id: I856eaa95df2b68fb35cbe00714f9a43af9537d4f
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!