| commit | b2f1be13c32f94a95880525543a7a78153df5571 | [log] [tgz] |
|---|---|---|
| author | Aleks Totic <atotic@chromium.org> | Tue Feb 02 22:54:13 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Feb 02 23:10:56 2021 |
| tree | 971686f9bf3e4b580dbbe697afa0558f7eaf23ac | |
| parent | 30273e41936ef71836fe14447be36055c02e5d5b [diff] |
[TablesNG] clusterfuzz: Fix underinvalidation when rowspan changes Clusterfuzz found a bug where ComputeMinimumRowBlockSize was accessing out of bounds column_locations. Cause: Table had dimensions 1x2 One cell mutates rowspan to 22 Table layout does not get invalidated, which causes CachedTableColumnConstraints not to get invalidated. This is because CachedTableColumnConstraints are cleared on SetNeedsLayout for table. Somehow, table does get relayout. This only happens when running inside test runner. My guess is that the runner somehow causes relayout without calling SetNeedsLayout. During relayout, table dimensions are now 2x2. But we only have 1 column, so go out of bounds when traversing column array. The fix is to invalidate table layout when colspan/rowspan change. This can be done in 2 places 1) Invalidate table layout in LayoutNGTableCell::ColSpanOrRowSpanChanged 2) Invalidate table layout in LayoutNGTable::TableGridStructureChanged TableGridStructureChanged also gets called when table parts are added/removed. All the other callers so far also call SetNeedsLayout. I've opted for 2), because table will always need layout when its structure changes. This bug also caused table not to relayout when rowspan/colspan changed. wpt test tests this. Bug: 1172651 Change-Id: I85496864eb0da7ff1bdacb58483bc1295a00e9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2661207 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#849799}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!