commit | a4d752185529f6c16f09652ee981ed5619dfd77d | [log] [tgz] |
---|---|---|
author | Mark Pearson <mpearson@chromium.org> | Sat Sep 09 00:03:07 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Sep 09 00:19:23 2023 |
tree | 214ee4e75c6c3de2539afce813ed81806d037b99 | |
parent | e77818a534e155243309adad5501fb0991444f89 [diff] |
Revert "Rewrite to re-enable pointerevent_attributes_nohover_pointers WPT" This reverts commit 994abcef8b47d22271d4efb910cc1a301934cffa. Reason for revert: Causes consistent failures blink_wpt_tests failed because of external/wpt/pointerevents/pointerevent_attributes_nohover_pointers.html?touch in the "WebKit Linux Leak" bot. https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak First failure is here: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/54788/overview Sadly, the failure message doesn't include any details as near as I can tell. https://luci-milo.appspot.com/ui/inv/build-8770492706891758241/test-results?q=external%2Fwpt%2Fpointerevents%2Fpointerevent_attributes_nohover_pointers.html%3Ftouch&sortby=&groupby= I hope you, as experts in this area, can figure it out. --- Unexpected failed Summary: command /b/s/w/ir/out/Release/content_shell --run-web-tests --user-data-dir --ignore-certificate-errors-spki-list=Nxvaj3+bY3oVrTc+Jp7m3E3sB1n3lXtnMDCyBsqEXiY=,55qC1nKu2A88ESbFmk5sTPQS/ScG+8DD7P+2bgFA9iM=,0Rt4mT6SJXojEMHTnKnlJ/hBKMBcI4kteBlhR1eTTdk= --webtransport-developer-mode --enable-crash-reporter --crash-dumps-dir=/b/s/w/ir/out/Release/crash-dumps --enable-leak-detection --disable-threaded-compositing --disable-threaded-animation - http://web-platform.test:8001/pointerevents/pointerevent_attributes_nohover_pointers.html?touch stderr #EOF --- Original change's description: > Rewrite to re-enable pointerevent_attributes_nohover_pointers WPT > > The test was written using complicated event-driven logic, and had two > tests hooked up together. We are switching it to a simpler > Promise-based approach like newer tests in the same folder, expecting > to address the leak issue. > > This is a partial re-land of reverted crrev.com/c/4794391 : we are > holding back (for a latter CL) the subframe part and keeping the test > disabled to ease debugging the leak on the bot. > > Bug: 1446799 > Change-Id: I3a8c0bb4cc7ecd3f400f7894d5195cf2c06f6d9b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853978 > Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> > Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Kevin Ellis <kevers@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1194278} Bug: 1446799 Change-Id: I5775c9b345049d12164c97cc16233e12f644ba62 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4854960 Auto-Submit: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1194380}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!