commit | 6830aff0b4a76f5e7deaeb30f934c4571b1e126e | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Wed May 08 21:56:39 2024 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed May 08 22:13:38 2024 |
tree | 50c5008ec3628417991544c243ffe91b164ec6ea | |
parent | 6813062aec0d15c12e292c3abbe584bf1a4cee8e [diff] |
@page background painting. In paginated layout, the document background (typically specified on the BODY or HTML element) is painted on the page border box. Additionally, @page rules may specify a background property, and this one is painted over the entire page, including the margin area. This one is painted before any document background. See https://drafts.csswg.org/css-page-3/#painting All document (fragmented) contents are painted by separate paint layers, i.e. the layer established by the document root (HTML), in addition to any other top layers. Page containers and border boxes, on the other hand, do not establish layers, and are painted normally under the paint layer of the LayoutView. When printing a page, have BoxFragmentPainter look up the page container fragment of the current page, and paint just that, with an infinite cull rect. PhysicalFragment::IsPaginatedRoot() wasn't entirely correct, since it would also return true for non-paginated documents, as long as we were printing. Iframes, for instance, are not laid out for pagination, but printed as-is. With the new callsites, these false positives would cause trouble. Fix that, and move the function down to PhysicalBoxFragment, to utilize IsFragmentationContextRoot(). Pre-paint now needs to visit page container and page border box fragments, in order to set the paint offsets correctly. Layout still doesn't set the correct offsets for the page border box (margins are still handled on the outside of Blink), so for now, make sure that the tests have zero margins. Bug: 40286153 Change-Id: Ie4808491f1a570b9d223caeea3fa815995989703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522582 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1298373}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!