commit | 812cbb3b0b98535bb50a641735f1ecf74ba1fb8e | [log] [tgz] |
---|---|---|
author | Javier Fernández García-Boente <jfernandez@igalia.com> | Tue Jan 12 11:00:20 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Jan 12 11:20:10 2021 |
tree | d15a925e6e4a9e330d4a082662b05de5027c4a14 | |
parent | 80090f6edd23993e9907dbc9fb1c6af7aebf91e7 [diff] |
Ensure the break-offset is greater than the non-hangable run end The ShapeLineBreaker::NextBreakOpportunity function determines the non-hangable run end based on the currently break-offset. This value is, by definition, always smaller than the break-offset. However, if the break-offset value exceed the range_end, we use this as the actual offset. If we have reached this scenario because there is no breaking opportunity to prevent the overflow, then we just call ShapeToEnd and return. Otherwise, we continue processing the text item. In this situation, we must ensure that the new offset is greater than the previously computed non-hangable run end, since it's possible that we end up using it as the final offset, leading to the assert violation described in the bug, since the used break-offset is smaller than the item's end. This CL adds the logic to prevent this situation, clearing the non-hangable run end and computing it again, if necessary, based on the new offset. Bug: 1161793 Change-Id: Ie10ffae3c654aefa626d80abd01bd38e026c9e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604908 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842461}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!