commit | 6fc4f27b2befb9e5cb8256fd41617dedd16d691a | [log] [tgz] |
---|---|---|
author | Frédéric Wang <fwang@igalia.com> | Fri Aug 13 23:54:14 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Aug 14 00:05:52 2021 |
tree | 5ead5895acd3e59219aa5a970e49b48e7659778f | |
parent | dd7717aa14d7948715053416e0c048087ee7422f [diff] |
Rely on the CSS serializer for CanvasTextDrawingStyles.font According to the canvas specification [1]: "On getting, the font attribute must return the serialized form of the current font of the context (with no 'line-height' component)." This patch changes the implementations of CanvasRenderingContext2D OffscreenCanvasRenderingContext2D so that the font-family part is serialized via the CSS serializer [2] [3] [4]. This reduces code duplication and makes things more consistent in preparation for [5]. In particular, this changes the following: - Font family names are always quoted when necessary (e.g. if they contain a quote or a comma), while this used to only be done when they contain an ASCII space U+0020. - The "-webkit" prefix prepended to some generic font families names (namely "cursive", "fantasy", "monospace", "sans-serif" and "serif") is removed ; while this used to be done for all font family names with a "-webkit" prefix. - Various character substitutions from [3] are performed, while no no such substitutions used to happen. One noticeable edge case is the escaping of double quote and backslash characters. The new serialization behavior aligns with Firefox. This is a considered a minor bug fix that "does not affect web API behavior to the point that developers need to be aware of it" and so is exempt from an I2S [6]. [1] https://html.spec.whatwg.org/multipage/canvas.html#text-styles [2] https://drafts.csswg.org/cssom/#serialize-a-comma-separated-list [3] https://drafts.csswg.org/cssom/#serialize-a-string [4] https://drafts.csswg.org/cssom/#serialize-an-identifier [5] https://bugs.chromium.org/p/chromium/issues/detail?id=1065468 [6] https://www.chromium.org/blink/launching-features Bug: 1065468 Change-Id: I7003705af8010cbb9723ee8d0a6c39e083f9eef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3086444 Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#911930}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!