| commit | d02695a83d483670b3cef6f2c6e492f698212700 | [log] [tgz] |
|---|---|---|
| author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Mon Sep 27 14:58:28 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Sep 27 15:09:54 2021 |
| tree | 17f86a3823b7067c4173dddfcd6d2b259cbffebc | |
| parent | 56ed85a0406138bbc8ab0db3bb0b8e54c09812db [diff] |
nfc: Limit amount NDEFMessage objects that can be nested. Implement https://github.com/w3c/web-nfc/pull/621, which adds a hard-coded maximum of 32 NDEFMessage objects that can be in the same chain. https://github.com/w3c/web-nfc/pull/454 (and https://chromium-review.googlesource.com/c/chromium/src/+/1941083 on the implementation side) ended up creating a cycle between NDEFRecordInit.data and NDEFMessageInit, as the former can be an NDEFMessage, which could have one or more entries pointing to the same NDEFRecordInit. Recursion in Web IDL dictionaries are disallowed, so this change also fixes some invalid IDL that was present in the spec and our IDL file. This CL attempts to optimize or modify other parts of the code as little as possible, but the the change ended up being a bit big mainly due to two things: - Since NDEFRecordInit.data's type is now `any`, we need to do more type conversions ourselves in NDEFRecord that we used to get for free when using IDL unions. This means attempting to convert a V8 value into one or more C++ types and accounting for conversion failures. - In order to do the above, we need access to v8::Isolate, so several functions in NDEFRecord that used to take an ExecutionContext needed to be changed to take a ScriptState instead. The usage of ScriptState and the need to perform multiple type conversions also caused NDEFReadingEvent's constructor to start passing one to NDEFMessage, which at the end causes the NDEFRecords that may get created to contain a proper `lang` attribute rather than null. This is a user-visible change, but I could not find anything in the spec supporting the previous behavior. Bug: 1242274 Change-Id: Ia4de230ea45f63f903760865bf85594f79da9eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169656 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/main@{#925263}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!