commit | a4d9d522de565a6aa85901421cf1e84e4b3423e6 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Mon Jan 17 09:12:51 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Jan 17 09:28:41 2022 |
tree | 142a53615dc08144fe3cbc30210ab03228d55af6 | |
parent | 6844256e002585b09857bd20603e5c7c5d6db8f4 [diff] |
Fix fragment post-layout cloning for multicol. Fragment post-layout cloning is needed for two things: 1. Rebuilding the fragment tree spine after subtree relayout 2. Recalculating overflow without laying out Don't store layout results on the flow thread. This was tricky to maintain and hard to reason about (we'd store fragmentainer children of the multicol container fragment, but not spanners, OOFs, list item markers etc.), Besides, we're going to remove the flow thread concept as soon as we can (which admittedly isn't *that* soon, though), so this will prepare us for the future. This also means that we should no longer set up FragmentData entries for the flow thread, so removed that code as well. When cloning a fragmentation context root fragment, we'll now also update the children of its fragmentainers to the post-layout fragments, since fragmentainers no longer have the concept of "post-layout" (line boxes don't have that, either, FWIW). For subtree relayout, all we need to do is making sure that we only visit NG containing blocks when rebuilding the fragment tree spine (i.e. skip any flow threads). For overflow recalculation, we're not making any specific changes in this CL at all; things will just start working (with at least one exception, but I'll get back to that in a follow-up), and stop crashing. The change in OwnerLayoutBox() (to never do anything special) would trigger a DCHECK failure in OffsetFromOwnerLayoutBox() when hit-testing (because the owner is the multicol container and |this| is a fragmentainer), which is why we will now never hit fragmentainers during hit-testing (and there should be no need for that anyway). Add an additional DCHECK (and documentation) to OffsetFromOwnerLayoutBox(), to make it clear that fragmentainers aren't supported. NGOutOfFlowLayoutPart::ReplaceFragmentainer() became a bit fancy, but it was the best I could come up with. This part was easier when we could just update fragments in the flow thread. Had to update the unit tests that expected any useful FragmentData from flow threads. Bug: 1279078, 1279525 Change-Id: I1d1c8366fe22f75e9a56a8e3f9910671f1ee81bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3378669 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#959971}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!