| commit | e79b44e0487c607344d8a6e7ee0278bed9821cea | [log] [tgz] |
|---|---|---|
| author | Clark DuVall <cduvall@chromium.org> | Fri Jun 24 00:56:14 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Jun 24 01:10:46 2022 |
| tree | dda3edd102a74db7c1a4ec80abfdb6a2486e4a2b | |
| parent | 53ae4d8624fc8a03548805de428cbc04155d59f7 [diff] |
Add TimedHTMLParserBudget to fieldtrial_testing_config.json This exposed cases where some web_tests were implicitly depending on the parser yielding at specific times. The fixes here should make these tests less brittle in general. These issues can be reproduced with the current token based parser logic by inserting a bunch of <span>s at certain places in the HTML to force the parser to yield. The list of fixes: - createImageBitmap-sizeOverflow.html: this test was just broken in general. It was not waiting for the assert_throws_dom code to run. The test is now fixed by switching to a promise_test. - resource-selection-invoke-*: These tests were depending on not yielding between scripts. The check they had in the separate script was not very important and was brittle, and in the sync version was already failing (see FAIL in expectations file). - track-selection-metadata.html: this test was depending on the parser not yielding after executing the script. This was fixed by moving the script outside the <video> element. - execution-timing/080.html: depended on the parser not yielding between scripts. - about-blank-replacement-blank-nested-frame.html: depended on parser not yielding between scripts. - fast/frames/*: exposed an existing bug where frame borders would not be drawn if the parser yields at certain times. Filed this at crbug.com/1338331. I fixed this by using CSS borders for the frames instead of frameborder. Bug: 1314493 Change-Id: I8ad7708659bc9690be2641a22bf4d5f24165dc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3716825 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#1017439}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!