commit | 57483c9910074efb2cfa6d41dbed261b81d3bede | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Wed Jun 29 11:48:33 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jun 29 11:57:03 2022 |
tree | 76d53653c9a6ecae96762daa8d0dde61f956ba3a | |
parent | bb66b98321db60735132cb0b8d88587477a0fd37 [diff] |
[@container] Clear results according to ContainerQueryEvaluator::Change In ContainerQueryEvaluator::ContainerChanged, we currently clear *all* results whenever we compute any Change other than kNone. However, for computed change=kNearestContainer it is not correct to clear results with change=kDescendantContainers, since in that situation we're not going to recalculate the container-query-dependent elements within nested containers, hence all the results aren't repopulated. This causes us to miss invalidation in some cases. Fixed by only clearing results less than or equal to the computed change. Also added additional assertions and comments to the test ContainerQueryEvaluatorTest.ContainerChanged. That change was prompted by the slightly unclear/inaccurate comment about results being cleared whenever ContainerChanged is called. It's better to be explicit about what we expect the results to be. Fixed: 1340351 Change-Id: I64467104b6b0eacef5100d67f6b8f8287a57d0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3732493 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1019074}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!