commit | 4e1dddf5a4bbd613747f04af48d9f150ff0a1df6 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Wed Jul 06 09:00:51 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jul 06 09:13:24 2022 |
tree | 28f92e06bf1dcf7dc7b3ef6beeea3d0f8b8954c3 | |
parent | 514941924839805f60dec72877751bf8294d060a [diff] |
Handle specified table block-size correctly when fragmented. Introduce table-specific break token data to make our job easier / possible. The break token will know the total consumed block-size of the "table box" (the table element, excluding captions), and also whether we have entered the table box and whether we're also past it. This involves some non-trivial changes to the table layout algorithm, so that we can calculate the intrinsic block-size correctly (which shouldn't be affected by the specified block-size), so that we can break correctly inside the table. The fragmentation machinery will not break inside if the intrinsic block-size is larger than available space, except for the space taken up by block-end border/padding. The machinery expects block-end border/padding to be included in the fragment size (it will subtract it again, if necessary), even if we know we're going to break inside. So we generally shouldn't omit block-end border/padding when laying out the fragment. That's one thing less for the table layout algorithm to worry about. Had to shuffle some code around, so that we invoke the fragmentation machinery before setting a table grid block-size. I also discovered that we set the table column block-size incorrectly when fragmented. Will address this in a follow-up CL, but added a TODO for now. Remove fragmentation/fragmented-table-with-fixed-height.html , since it's invalid. It expects a table's specified height to be ignored if the table gets fragmented, which is what the legacy fragmentation engine does. This also happens to fix crbug.com/1251689 , which is about a flexbox with a table inside that establishes an orthogonal writing mode. Probably fixed by the fact that we no longer let specified block-size (and flex-basis, I suppose) affect the intrinsic block-size of the table. The table layout algorithm has some hacks for intrinsic block-size calculation when inside a flex container, which probably didn't work in this particular case. Maybe we can remove that now. Bug: 1335881, 1251689 Change-Id: I9a803daf5f08647aaa019ff0484e425406bc7d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3745936 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021095}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!