commit | f4436414776f29b19055b5da569f301861f44cf3 | [log] [tgz] |
---|---|---|
author | Delan Azabani <dazabani@igalia.com> | Fri Jul 15 04:05:52 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Jul 15 04:22:35 2022 |
tree | 7179155ec3c754dfc3b84ef90ef4d58877519999 | |
parent | ed5e1813557a68c0cf400236b10cec22b92f7f1f [diff] |
Reland "Reland "CSS highlight painting: bump HighlightOverlayPainting to stable"" This is a reland of commit 387b61732a4ca2f25d7aa5b376de0d373e4e72c2, which was reverted because it caused a perf regression (bug 1335762). Since we’ve more or less eliminated the regression in CL:3726437 (was CL:3720688) and CL:3759693, the reason for revert should be resolved. This patch is the same as the original change except: • text-decoration-color-selection-001.html is no longer expected to fail, because the test has been removed from WPT (bug 1321106) • highlight-pseudos-currentcolor-visited-computed-001.html refers to more precise bugs in its failure expectations (bug 1341621 or bug 1147859 for disable-layout-ng, not bug 1295264) • Some screenshot tests that needed rebaselining in the original have yielded different sets of expectations due to bot changes, but the substance of the rebaselines and the tests involved are the same Original change's description: > Reland "CSS highlight painting: bump HighlightOverlayPainting to stable" > > This is a reland of commit abc6f616c7bc2c53cc9d8c44b82384d43dd77d02 > > Original change's description: > > CSS highlight painting: bump HighlightOverlayPainting to stable > > > > This patch enables the new highlight overlay painter. The rebaselined > > tests and their reasons are as follows: > > > > • no more double painting bug > > • dark-mode/colors/selection.html > > • originating decorations are now recolored per spec > > • editing/selection/line-wrap-2.html > > • virtual/text-antialias/selection/khmer-selection.html > > • spelling markers are now *consistently* painted over text > > • paint/markers/document-markers-font-8px.html > > • paint/markers/document-markers-zoom-2000.html > > • decorations are now clipped to highlight background rect > > • svg/text/text-selection-deco-01-b.svg > > • svg/text/text-selection-text-03-b.svg > > > > The only new failure expectations are as follows: > > > > • external/wpt/css/css-pseudo/highlight-painting-003.html broadens > > from Mac11 to Mac (like we had to do in CL:3608432) > > • external/wpt/css/css-text-decor/text-decoration-color-selection-001 > > fails because the test is incorrect (bug 1321106) > > • paint/markers/suggestion-marker-basic.html fails because it’s not > > clear the assertion still complies with the spec (bug 1321114) > > > > Some tests had bugs that we’ve fixed in this patch: > > > > • external/wpt/css/css-pseudo/target-text-text-decoration-001.html > > had a bug where it assumed UA default highlight colors would be > > suppressed by an author ‘text-decoration’ > > > > Bug: 1147859 > > Change-Id: Ie4d8dae515a786fa01e8f2852d645f3a8ad313be > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3616170 > > Reviewed-by: Stephen Chenney <schenney@chromium.org> > > Commit-Queue: Delan Azabani <dazabani@igalia.com> > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1001604} > > Bug: 1147859 > Change-Id: Icd150ff8c695d20a5c9f44df45d5e0751c31f79a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3640642 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Delan Azabani <dazabani@igalia.com> > Cr-Commit-Position: refs/heads/main@{#1001937} Bug: 1147859 Change-Id: I42ea7d56b029e933cfae12bf12c17d4bb46ffbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3739907 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1024571}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!