commit | c0883fdb59a783615470067f728818e2abf96b1f | [log] [tgz] |
---|---|---|
author | Delan Azabani <dazabani@igalia.com> | Tue Aug 16 15:05:10 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Aug 16 15:17:49 2022 |
tree | 7b5eef91fda922c9e00b3b65f1bca683d8d9d9ca | |
parent | 2364c1455ef1e64ee7333f83d3626ab825227580 [diff] |
HighlightOverlayPainting: fix ‘text-decoration-skip-ink’ Underlines skip descenders when ‘text-decoration-skip-ink’ is ‘auto’, but this relies on NGTextPainter having the correct range to compute the text intercepts over. NGTextPainter is stateful, with a mutable NGTextFragmentPaintInfo that affects things like the calculation of text intercepts for skip ink. This is generally not a problem, but for highlight painting we break the text fragment into parts, often painting text for one range then decorations for another. This means we might compute text intercepts for the wrong range. This patch fixes that bug by eliminating the NGTextFragmentPaintInfo field, making functions that need one take it as an argument. To make it easier to safely slice NGTextFragmentPaintInfo, we add methods to do that while checking that the new range is a subrange of the old range. That way, any guarantees the caller wants to make about the StringView and/or ShapeResultView in the old instance remain true for the new instance (for example, some callers don’t care if there’s a valid ShapeResultView, and sometimes it’s nullptr). To avoid messy template member functions, we duplicate a small method (PaintDecorationUnderOrOverLine) for legacy, and move two others from TextPainterBase into a new NGTextPainterBase, which contains LayoutNG- specific code shared between NGTextPainter and NGTextCombinePainter. Fixed: 1350469 Change-Id: Ic51ff58da4e2a80bae2527f7ea90b57b9e361000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820621 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/main@{#1035509}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!