| commit | e8cba6918a23cc46ebfb7c83c7439f3abc0aa973 | [log] [tgz] |
|---|---|---|
| author | Scott Haseley <shaseley@chromium.org> | Fri Jan 06 16:59:35 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Jan 06 17:07:25 2023 |
| tree | 224969e8742627a5cda9b9690c64d64bdc810363 | |
| parent | 522047d2680b8a25480d53d1ee7161a60b3fe748 [diff] |
[dom] Implement AbortSignal.any() prototype
This adds the basic functionality for AbortSignal.any(), which creates
a new signal that will be aborted if any of the signals associated
signals are aborted. The API is implemented behind a flag.
The general idea and concepts are:
- A signal created with this API is a "composite signal", composed of
0 or more "abort sources".
- An abort source can be any AbortSignal, but since the relationships
are established at signal creation time, we can link to non-composite
signals, i.e. those associated with a controller.
- If any of the abort sources are already aborted when this API is
called, it returns an aborted signal (with the culprit's reason).
- During SignalAbort, a signal will invoke SignalAbort on all of its
"dependent signals" (those for which it is a source).
Most of this is implemented by AbortSignalCompositionManager. In this CL
this class handles linking source/dependent abort signals, but in
follow-up CLs this will also:
1. Also manage priority sources for composite TaskSignals, which are
created by a specialization for TaskSignal.any(). The logic for
managing abort and priority sources/dependents is the same, so this
setup is optimized for code reuse. Note also that the WPT tests for
for AbortSignal.any() are implemented in resources/ and pulled in
via META statements for reuse with TaskSignal.any().
2. Handle more complex memory management. Memory leaks can result from
composite signals following long-lived top-level signals, which we
expect to be a common pattern and part of the motivation for the UA
maintaining the signal relationships. This is separated out to keep
CLs smaller.
Explainer: https://github.com/shaseley/abort-signal-any
I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/FSH6hrJMaxM/m/Ft8KiGlbAAAJ
Design doc: https://docs.google.com/document/d/1LvmsBLV85p-PhSGvTH-YwgD6onuhh1VXLg8jPlH32H4/edit?usp=sharing
Bug: 1323391
Change-Id: Ibc85815b166fd4242543f30600be99fadf35992e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703640
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1089752}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!