commit | c600fdea10babeeb9961f019c8fd62aa18bda645 | [log] [tgz] |
---|---|---|
author | Frédéric Wang <fwang@igalia.com> | Tue Jan 10 10:40:05 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Jan 10 10:50:52 2023 |
tree | bdb7e8f05da0a36c0cea91eadd2d84a7ef361bbe | |
parent | 9db183a1c94a81f3963528e3b075e6c33270240d [diff] |
[mathml] Refactor parsing of mspace and mpadded attributes Currently, the mspace and mpadded elements use different approaches to parse the width/height/depth/lspace/voffset attributes: - AddPropertyToPresentationAttributeStyle for the value (sometimes excluding values that ends with a '%' character). - AddPropertyToPresentationAttributeStyle for a calc expression built from the values of the height and depth attributes. - Using AddMathLengthToComputedStyle (sometimes accepting percentage) which relies on CSSParser::ParseLengthPercentage, but these parsing methods seem incorrect. The initial goal was to use the default value when a percentage is specified and this is what is currently specified in MathML Core [1] [2]. However, the current implementation has bugs that make percentage accepted in some cases [3] or unnecessarily mapping invalid values to presentational hints. This CL tries to bring more consistency on the parsing side by always delegating the parsing of the attribute value to CSSParser::ParseLengthPercentage before mapping it to presentational hint or internal properties. The parsing parameter AllowPercentages::kNo is used to ensure percentages are always treated as invalid. CSSParser::ParseLengthPercentage is also refine to always trim whitespaces, and check there is no remaining token after the parsed <length-percentage>. This refactoring will facilitate specifying Chrome's behavior in MathML Core regarding interaction with CSS width/height properties, handling of percentages and use of presentational hints [4]. [1] https://w3c.github.io/mathml-core/#space-mspace [2] https://w3c.github.io/mathml-core/#inner-box-and-requested-parameters [3] crbug.com/1402998 [4] https://github.com/w3c/mathml-core/issues/75#issuecomment-1359541618 Bug: 6606, 1402998 Change-Id: Ibe4e49af4c3f4aeb5c153e10b4ba93d26db20849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4120274 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1090758}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!