| commit | 4cff0d912a88553c5896c642f3a743dc94b9bbf5 | [log] [tgz] |
|---|---|---|
| author | Steinar H. Gunderson <sesse@chromium.org> | Tue Feb 28 11:28:45 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Feb 28 11:39:45 2023 |
| tree | 6a648f6975e102f0e4fdae84cedc78c54160eb08 | |
| parent | 7906118b285a463cf294f898dfd979f8c8ad44d0 [diff] |
Fix a DCHECK with easy selector matching in case-sensitivity corner cases. There's a small performance hit from this fix, but we do get to check slightly more elements in the easy selector checker, so it's not too bad in most cases. Style perftest (Zen 2, LTO but no PGO): Initial style (µs) Before After Perf 95% CI (BCa) =================== ========= ========= ======= ================= ECommerce 9884 9883 +0.0% [ -0.1%, +0.1%] Encyclopedia 106558 106312 +0.2% [ +0.1%, +0.3%] Extension 131017 130938 +0.1% [ -0.0%, +0.2%] News 40452 40549 -0.2% [ -0.4%, -0.1%] Search 2584 2589 -0.2% [ -0.3%, -0.0%] Social1 22265 22259 +0.0% [ -0.1%, +0.1%] Social2 1028 1032 -0.5% [ -0.6%, -0.2%] Sports 41938 41990 -0.1% [ -0.2%, -0.0%] Video 40186 40311 -0.3% [ -0.4%, -0.2%] Geometric mean -0.1% [ -0.2%, -0.0%] Recalc style (µs) Before After Perf 95% CI (BCa) =================== ========= ========= ======= ================= ECommerce 11151 11228 -0.7% [ -0.9%, -0.5%] Encyclopedia 83864 84208 -0.4% [ -0.5%, -0.3%] Extension 118404 119177 -0.6% [ -0.8%, -0.5%] News 29341 29482 -0.5% [ -0.7%, -0.3%] Search 236 238 -0.9% [ -1.7%, -0.4%] Social1 16021 16088 -0.4% [ -0.6%, -0.3%] Social2 577 579 -0.4% [ -0.7%, -0.2%] Sports 22037 22277 -1.1% [ -1.2%, -0.9%] Video 24092 24376 -1.2% [ -1.3%, -1.0%] Geometric mean -0.7% [ -0.8%, -0.6%] Fixed: 1418575 Change-Id: I82b28b7cdebeb9ffc24e54a86a0993443d566278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4286739 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1110864}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!