commit | 4e64b646662678a6ba01e7fd5847fd8bdbf47fb2 | [log] [tgz] |
---|---|---|
author | Mason Freed <masonf@chromium.org> | Wed Oct 04 17:40:56 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Oct 04 17:59:29 2023 |
tree | fcc7f09753e721829cf8c5c0ebfcb4a784d8d862 | |
parent | 161e1f9770abe9f9667e658a9c9b88039a6ab65b [diff] |
Optimize several things about DOM Parts [2/2] This CL continues the optimization work, with these changes: - Replace ClonePartsFrom() with PartRoot::CloneParts(), to centralize the part cloning functionality into a single place. - Replace NodeCloningData's HeapHashMap architecture with a much simpler stack architecture. Also eliminate the cloning part queue, and replace it with a clone-as-you-go approach. With this new system, as a Node containing Parts is cloned, the Parts are iterated and cloned, validating them with IsValid first. As ChildNodeParts are encountered, they are cloned with both sibling nodes pointing to the same node, and the new ChildNodePart is pushed onto the part root stack. As the next_sibling is encountered, the ChildNodePart is updated to have the correct sibling node, and the part root stack is popped. All of this together achieves the same behavior, but with much lower speed cost. - Part::IsValid() is cached to improve speed, and disconnected_ becomes connected_ to avoid a `!`. - PartRoot's cached parts list is converted from a Deque to a HeapVector, which is more efficient. That eliminates the ability to modify the front of the list, so this will adversely impact performance for some operations when DOMPartsAPIActivePartTracking is enabled (off by default). Bug: 1453291 Change-Id: I2a2025dd4d1e0c1fa4c85a21469526f6ff1f86d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4909445 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1205329}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!