commit | b71ded018fcecc54f69d7c4e399dd0b9b00eab06 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Fri Feb 26 08:36:15 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Feb 26 08:52:07 2021 |
tree | 0fb8ed172bce5c86821aae256f9b11ad3c4f8a5b | |
parent | fef1c092193085ce2fa64fd116484ba0f3c0dbb1 [diff] |
Never force legacy layout on NG objects. Remove dangerous legacy fallback code from LayoutObject(), and do this safely in the child insertion code instead. Calling a virtual method in a base class constructor doesn't work. IsLayoutNGObject() would always return false, since that's how it's implemented in LayoutObject. This code could cause us to mark an NG object as requiring legacy fallback, which would make the NG engine delegate the job to the legacy engine. But the legacy engine would refuse to do anything, since it's an NG object, so it would delegate to NG, and so on... Infinite recursion. The !IsLayoutNGObject() check in LayoutObject() was a mistake added in CL:2414289, which basically had no effect at all. But we can just remove the entire thing now, and rely on the new hook in the child insertion code instead. Note that the new test doesn't fail without this fix when run normally by the test runner, because the test needs LayoutNGTextControl to be disabled in order to fail (so that we attempt legacy fallback), but this feature is currently set to "test". Unlike the fuzzer, it seems... Bug: 1181687 Change-Id: I2f174824e4b86d9ae2e5b3b319df7f6036b4f13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720104 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#858052}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!