commit | bb119aba885511cb6c57c654c11a281cda5d5d74 | [log] [tgz] |
---|---|---|
author | Mike Wasserman <msw@chromium.org> | Sat Feb 27 02:27:54 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Feb 27 02:47:56 2021 |
tree | 2181f3b091893b2573e368334eb7bd02215b4d1a | |
parent | 48af5d410146da01b1a8f695db7ab2470bbbbdd6 [diff] |
Window Placement: Implement Screens and ScreenAdvanced interfaces This CL makes the following changes for a planned API redesign: docs.google.com/document/d/1lgCentReLlym6j9kBS_Qo3r2HHZ6Ov7cSGjSWyi8cYs 1) Add Screens interface to vend multi-screen info for windowing. - RuntimeEnabled and permission-gated; designed like window.screen. 2) Add ScreenAdvanced interface, to extend Screen with extra info. - Make Screen impl non-final; override functions in ScreenAdvanced. 3) Add WindowScreens supplement, to host Window.getScreens(). - Rename the previous API access point to getScreensDeprecated(). 4) Add ScreenInfo::is_primary & is_internal to expose in ScreenAdvanced. - Add ScreenInfo::display_id for internal logic, it is not web-exposed. 5) Propagate multi-screen VisualProperties from browser to renderers: - Replace the singular ScreenInfo member with a new ScreenInfos struct. - Encapsulates multi-screen information and a current screen id. - Add [mutable_]current() for easy/legacy access to the current screen. - Validate mojo struct traits in [de]serialization; add tests. 6) Update WidgetBase, ChromeClient, tests, and more code accordingly. - Update RenderWidgetHostViewMac's cached display::Display on changes. - Add CoreInitializer plumbing to fire Screens.change in modules/. FOLLOWUP: Refine Screens::ScreenInfosChanged implementation. FOLLOWUP: Propagate multi-screen info to RemoteFrames. FOLLOWUP: Update/add tests; remove old API and plumbing. FOLLOWUP: Add WindowScreens PermissionObserver & set_disconnect_handler? FOLLOWUP: Use WebContentsImpl's NativeView in RWHI::GetScreenInfo? Bug: 897300, 1116528, 1138596, 1169312, 1116528, 1179876, 1179945 Test: New API roughly WAI w/ --enable-blink-features=WindowPlacement Change-Id: I1d67cfabda62796274992e3e650d5209dd7bb857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2669359 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#858379}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!