commit | 0e16f34e25e621bccf287f93c8c7034bdc7422e1 | [log] [tgz] |
---|---|---|
author | Alison Maher <almaher@microsoft.com> | Mon Apr 12 20:04:56 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Apr 12 20:26:29 2021 |
tree | 32da143ae71bd75b77f4fcda5bda621370516758 | |
parent | 4dacbef66dc3ab3091934de9a3ddac376f1e6608 [diff] |
[LayoutNG] Nested fixedpos in a multicol When a fixedpos is nested in an abspos inside a multicol, and its containing block is inside the multicol (for example, a transform), it fails to get laid out. The reason being that its abspos ancestor is laid out once it reaches the fragmentation context root, resulting in the fixedpos never finding its containing block. To fix this, we now store an additional containing block fragment and offset inside NGOutOfFlowPositionedNode for any fixepos descendants. This gets set when the first potential fixedpos container is encountered as an out-of- flow fragmentainer descendant makes its way to fragmentation context root. If the out-of-flow element has a fixedpos descendant, this extra containing block info is used to perform layout on that descendant. Because we are now storing two containing block fragments/ offsets in NGOutOfFlowPositionedNode, a new struct called NGOOFPositionedContainingBlock was added to hold the fragment and offset for each containing block inside NGOutOfFlowPositionedNode. Additionally, the code that checked for the breakability of an element resulted in all fixedpos elements becoming monolithic. However, they should only be treated as such if their containing block is the viewport. The web test that had been added to test the old behavior has been deleted, and new wpt tests have been added to test that fixedpos elements with a non-viewport containing block break properly. Bug: 1188757 Change-Id: I450749184917f374ea46ed006d6a9989849bb7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2791850 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#871592}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!