commit | 16e47e623385c2ff468cd10fcb9d42b78d2b8e80 | [log] [tgz] |
---|---|---|
author | Alison Maher <almaher@microsoft.com> | Fri Apr 16 01:07:45 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Apr 16 01:32:21 2021 |
tree | 2d6288ea1a3d1920516963f7889938f84d225cae | |
parent | 23ae23071d3c44ee4b6b5a625498229f6107a31c [diff] |
[LayoutNG] OOF positioned offset in a nested multicol OOF positioned elements (abspos or fixedpos) in a nested multicol could get the wrong offset if the containing block started in a column that was not the first in a given multicol fragment. The reason being that we had adjusted the containing block offset in CL:2680070 to take into account columns from previous fragments. However, if the containing block was not in the first column in a multicol fragment, we would have already adjusted for this in NGContainerFragmentBuilder (given that its column's builder would have access to the previous column break token). To fix this, utilize the previous_break_token_ stored in NGBoxFragmentBuilder (which is available in both cases above) to determine the correct offset for the containing block. Instead of passing both this adjustment for the containing block and a bool to determine if we should propagate OOFs, a new base::Optional<LayoutUnit> variable is passed into PropagateOOFPositionedInfo() to determine both (credit: CL:2827892). This containing block adjustment is determined in NGBoxFragmentBuilder::BlockOffsetAdjustmentForFragmentainer(). Bug: 1198578 Change-Id: I3c183dd83ed45e240fb9f62347dd388e370b1510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822985 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#873126}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!