commit | a03cfd4a78f41f6b463445ab25de166b35af7110 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Tue May 11 12:01:50 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue May 11 12:17:56 2021 |
tree | b7bda875f831e70dfe3c419bc9fd5577bb62f116 | |
parent | ee6431de05ac818248d2a41d7a96ab9c36e6b6d8 [diff] |
Correct list-item marker positioning in multicols. Place list-item markers of a multicol container beside a spanner, if the spanner has a baseline and there's no preceding first column with a baseline. If a spanner has no baseline, also keep looking for suitable columns after the spanner. If no suitable multicol child fragment has a baseline, fall back to placing the marker at the beginning of the multicol container. This matches the behavior in the block layout algorithm. In the simple cases we were already handling multicol list-item marker positioning correctly, given that the first column had a baseline. In such cases we'd lay out and add the marker inside the first column fragment. Since the first column may not be the destination for the marker, this CL will instead consistently put the marker as a direct child of the multicol container (not inside a column). The block layout algorithm will now always propagate the marker to the multicol container if it's a list-item (rather than attempting to handle it on its own). Remove two DCHECKs that are no longer sufficient. We could add list-item markers as another exception to those DCHECKs, but removing them seems better at this point. Bug: 1130451 Change-Id: Idb4b950079d3cfdd7bc3a935b5b373a5a9f54aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2875086 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#881489}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!