| commit | 380dd71fdb7fe4a22a88389e61759bb1f988434f | [log] [tgz] |
|---|---|---|
| author | Alison Maher <almaher@microsoft.com> | Tue Aug 03 22:55:43 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Aug 03 23:06:25 2021 |
| tree | 877c072ee38e93f9e0b28a17a92ae39381bbe902 | |
| parent | 34e20f134472dc923d02206fe13819681ca63155 [diff] |
[LayoutNG] OOFs and column balancing OOFs should affect column balancing: https://github.com/w3c/csswg-drafts/issues/6279. As an initial implementation, this CL allows OOFs to affect the initial column balancing pass, which won't handle every case, but it should handle the cases of most interest. To accomplish this, lay out the OOFs normally inside their containing block during the initial column balancing pass, allowing the OOF to affect the initial column block size estimate. In order for the OOF to also affect the TallestUnbreakableBlockSize(), we needed to set up the constraint space in this case for fragmentation and propagate this information to the containing block's builder. Because OOFs now affect the initial column block size, there ended up being strange results when an OOF was discovered before a spanner. The OOF would affect the column block size for the columns before the spanner, but we would wait to layout the OOF officially until the multicol had finished layout. Because of this, we ended up adding new columns after the spanner with a smaller column block size. To fix this, this CL adds logic to the column layout algorithm to lay out any OOF descendants when we find a spanner using the newly added NGOutOfFlowLayoutPart::HandleFragmentation() function. This ensures that any OOF descendants found before a spanner are actually laid out before the spanner and take up the block size that they had initially contributed to. (See the updated unit tests as an example). Note that this doesn't work for nested fragmentation, and the related unit tests still result in slightly different behavior than the unnested case. Bug: 1206618 Change-Id: If21e1cac970289e569be9ab1a79030329732d613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018723 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#908157}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!