commit | 7e74e2aaa980a324714e8799667735f10083291f | [log] [tgz] |
---|---|---|
author | Andrew Wolfers <aswolfers@chromium.org> | Thu Oct 07 14:02:17 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Oct 07 14:17:13 2021 |
tree | b2de3724b980ac036ca9b431ce2b868884242cf4 | |
parent | 9a88dfd5bf623a8cb326c154b27f1e3494e11022 [diff] |
blink: Fix flipped orientation of transferFromImageBitmap ImageBitmapRenderer.transferFromImageBitmap results in images flipped upside-down when the image source is rendered with a WebGL context. The upside-down behavior is only observed on CrOS devices. Update the ImageLayerBridge flipping logic to be correctly oriented. Replace the existing logic which checks whether the image source is backed by a texture, because that does not consistently describe how the image source is oriented across OSes. Instead, rely on the origin of the image as the source of truth for describing its orientation. Additionally add web platforms tests to verify the orientation when the source image is rendered with a WebGL context, which complements existing tests covering the 2d-rendered case. Because web platform tests do not support testing on CrOS, see dependent CL https://crrev.com/c/3199838 in which Tast tests are added to test the same behavior. Bug: b:186464068 Change-Id: Id0f49d07959629b94340eaa02ab32394864e3242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171576 Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Andrew Wolfers <aswolfers@chromium.org> Cr-Commit-Position: refs/heads/main@{#929175}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!