| commit | c8131af860cd65db70f7a5adc921f313db7aec5a | [log] [tgz] |
|---|---|---|
| author | David Bokan <bokan@chromium.org> | Wed Oct 20 19:17:06 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Oct 20 19:40:52 2021 |
| tree | 4628f54e3bcdab7f4b06a72110a73dae1ba9f07c | |
| parent | 5f0a02b920a9183379260b5cd62b99fe4a148f37 [diff] |
Fix element hash fallback in iframes The text directive element-id fallback tries to scroll to the element-id if a text match wasn't found. It does so in PerformPreRafActions since element fragments cause focus which can execute script. Invoke(), where the text fragment performs its text search, occurs from lifecycle updates where script execution is forbidden. Text directives used to be limited to main-frames but were enabled explicitly for iframes in https://crrev.com/a71830a90b72f0a613fe9. However, PerformPreRafActions wasn't updated to call into the FragmentAnchor of an iframe We also need to strip the fragment directives in ElementFragmentAnchor::TryCreate. In cases where a text fragment is successfully created, the element id fallback works by creating an ElementFragmentAnchor from inside TextFragmentAnchor. However, if the TextFragmentAnchor is blocked or not parsed correctly, the URL passed to ElementFragmentAnchor in FragmentDirective::TryCreate will still include the directives. A test for this was added in the new same-document.tests.html Bug: 1260135 Change-Id: Ib3f19b462016d34cc41d21b05933aa9cb822a9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224519 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#933575}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!