| commit | 0b044312ec1d3dc5a91ab6701276fcacaca04836 | [log] [tgz] |
|---|---|---|
| author | Greg Thompson <grt@chromium.org> | Mon Nov 29 11:18:46 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Nov 29 11:25:06 2021 |
| tree | e1a0ccdbf93e16a25198dc5d1d8a3b3f84b5d5f0 | |
| parent | 45757066960382cf9cb7828a1db8859bed766bcc [diff] |
Revert "Initial support for text-decoration-line: spelling|grammar-error" This reverts commit 643df2d079fac73cb420e6cd074c79d5a739f63d. Reason for revert: text-decoration-line-grammar-error.html and text-decoration-line-spelling-error.html fail consistently on Mac10.12 Tests Original change's description: > Initial support for text-decoration-line: spelling|grammar-error > > This adds the initial support for spelling-error and grammar-error > values of text-decoration-line property. > > Main changes are in TextDecorationInfo, where we need to support > the new values and paint the decoration correctly. > In Mac platform we use a dotted decoration to match > the platform conventions. > In other platforms we use a wavy decoration, but we modify it > so it looks similar to the spelling and grammar markers > in Microsoft Word. > > It's important to note that this is just an intermediate step, > as this is different than how we currently paint > the spelling and grammar errors in DocumentMarkerPainter. > The idea would be make DocumentMarkerPainter use CSS text decorations > and then use this new code added here. > > There are some known issues: > * The underline offset is not the same than in Microsoft Word, > but that's because of a problem with regular underlines > not using the font metrics to compute that offset (crbug.com/1273042). > * We should allow to tweak the color with text-decoration-color, > added a TODO about that. > > BUG=1163436 > > Change-Id: I117ad38fe3fc805619eb47b1df2f48c9d7c9a351 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297885 > Commit-Queue: Delan Azabani <dazabani@igalia.com> > Reviewed-by: Delan Azabani <dazabani@igalia.com> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/main@{#945876} Bug: 1163436 Change-Id: I2622bde37f2f8a7f725a1a06be8d34acdf9f728b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306392 Auto-Submit: Greg Thompson <grt@chromium.org> Owners-Override: Greg Thompson <grt@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#945903}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!