commit | 4401bb56f90668983f6c237523a85f8875be9c77 | [log] [tgz] |
---|---|---|
author | Arthur Hemery <ahemery@chromium.org> | Tue Nov 30 10:41:43 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Nov 30 10:48:13 2021 |
tree | a27925ff17da4d1c886e46315b4dd8c22e6b120e | |
parent | a50d831a8108b74193d0ac8f731c7d90dd1cb001 [diff] |
[Fixit] Make sandbox + COOP break the opener. Sandbox flags and COOP cannot currently live on the same page. This was decided when first implementing COOP. If COOP and sandboxing flags are present on the same top level window, we return an error page instead, and COOP has no effect. Exploits have been discovered recently about abusing an opened window and history to be able to guess the cross-origin url using the history API. See: https://bugs.chromium.org/p/chromium/issues/detail?id=1208614 Error pages were left out from the fix, because it would be inelegant to insert error pages into history after a successful reload. That means error pages can potentially be used to guess a cross-origin URL. If in general this is acceptable, in our case its worse for two reasons: - COOP is used to protect pages that are usually more valuable or hold important data. - It is possible to reach an error page after response without relying on timing, etc. Therefore we'd like to sever the opener when we fail after receiving a response, if the target page did set COOP. Basically we'd like to change the spec to enforce COOP even when we fail because of COOP+sandbox. Spec discussion can be found here: https://github.com/whatwg/html/issues/7345 On the implementation side, this patch adds the WPTs necessary to the spec change, and the modified behavior. We add a setter to the swap parameter to be able to only activate that without breaking the COOP: Unsafe-none for error pages invariant. This applies to final responses and redirects. This does not alter the reload behavior, as this only happens for cases where reloads would not be successful anyway. Bug: 1256823 Change-Id: Ic79623a2b752608bc46a031d1f567308441d42e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293412 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#946387}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!