commit | 2c6485bc2c46775f044b5c704d6ff61683b529d7 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Tue Feb 15 00:49:48 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Feb 15 00:55:50 2022 |
tree | 15d1107843efafae27d83882442515a6cbe902ce | |
parent | bf69f477c59f900824af5e9178bd12ecab5b6498 [diff] |
Don't allow NG layout inside a forced legacy subtree. Display types like custom layout and MathML have no legacy implementation, so we used to force LayoutNG on such subtrees, even if we were already forced by the ancestry to do legacy layout. It turns out that handling this is just too hard, at least for pre-paint. Even if we forced NG layout in a legacy subtree, CanTraversePhysicalFragments() in LayoutObject would still return false [1], and pre-paint would treat a multicol container as a legacy multicol container, even if it was NG. This won't work, because the code expects the flow thread to establish a paint layer, which is only true if it's actually a legacy multicol container. So we crashed. Instead, for such display types, just create a LayoutBlockFlow if we're inside legacy layout. These features (custom layout / MathML) will no longer work inside a legacy subtree, but that shouldn't be much of a problem, since we won't ship those until the legacy engine is gone anyway. This will break one MathML test, which has math inside an SVG foreignObject (which is a legacy layout object). See crbug.com/989916 Remove the layout tree structure expectations from two unit tests that assumed that we support NG inside of legacy. We'll now only check that they don't crash. [1] See crbug.com/1289999 - we need to prevent fragment traversal, or the number of FragmentData objects and NGPhysicalFragment objects will mismatch - pre-paint will slice tall monolithic content because it's in legacy multicol (because legacy doesn't understand what monolithic means), while NG layout has only created one NGPhysicalFragment, because it's monolithic. Bug: 1291449, 1296664 Change-Id: I3ebd38ccff578884678b3edeacdf482e57de7b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3461697 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Oriol Brufau <obrufau@igalia.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#970937}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!