commit | 508eb59857af1c7be84b6101d0912ea5b320b147 | [log] [tgz] |
---|---|---|
author | Rune Lillesveen <futhark@chromium.org> | Thu Feb 17 15:43:34 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Feb 17 15:56:54 2022 |
tree | 9208a0a438c19b6741eda8284a52dbde0538a988 | |
parent | a674a29c3af735ed2ff4fbb02e53de380215fbf9 [diff] |
Fix crash with content-visibility forced detach The problem was that HTMLSlotElement::DetachDisplayLockedAssignedNodesLayoutTreeIfNeeded() was called as part of a slot assignment recalc done from AdjustDirectionalityIfNeededAfterChildrenChanged() from ChildrenChanged() in ContainerNode::RemoveChildren(). The detach scope object also covered ChildrenChanged, while the DisplayLock forced detach did not have a dom removal scope. Moved the detach scope around the actual removal and not surround the ChildrenChanged() hook. If detaches happens in those hooks, the root LayoutObject may even be different from the ContainerNode parent of the removal. Those should have their own scopes if necessary. Also, use in_detach_scope_ instead of in_dom_removal_ to figure out if we should store the parent_for_detached_subtree_. We don't add a scope around DetachDisplayLockedAssignedNodes... because we do not want or need any layout tree adjustments inside the locked subtree done by MarkForLayoutTreeChangesAfterDetach(). Bug: 1284278 Change-Id: Ibf4d4e21ddd9ad25e6bb0b013ca375b3b5b71ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468539 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#972445}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!