commit | c4685f7e4b654d5ee7a1b37466286e782747d2b9 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Thu Feb 17 20:05:40 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Feb 17 20:12:35 2022 |
tree | 32c70de4e6ce8b81614bcfabbc51f3338875f787 | |
parent | 031253008b4785a98e4005361580705ccd6b556c [diff] |
Handle resumed blocks that get sliced by floats correctly. Floats may be pushed from one fragmentainer to the next, and thus get in the way for blocks that started in the former fragmentainer, which means two things: 1. The resumed block may not start at the fragmentainer block-start (this was already working correctly) 2. The resumed block may not be able to fit anything at all in the next fragmentainer (if the float is tall enough). This was failing. We'd end up inserting a break before a node that we had already started, causing a lot of trouble. We'll now allow fragments of resumed blocks even if we're out of space (their block-size will typically be 0, i.e. no visual effect). We cannot just break before them, as that would restart layout from scratch once we get to a fragmentainer that has room (and a lot of other weirdness, e.g. confusing anyone trying to use the break token sequence numbers). As for the crash test included in this CL, we'll actually fit a portion of the nested multicol container below the content edge of the float in the first fragmentainer, and then resume the rest after the tall bottom padding of the float (which gets pushed to the second outer fragmentainer, since it's unbreakable). This is a bit weird, but probably acceptable. Bug: 1289532 Change-Id: I6f564652aca170b3cba80a3e01209984be206f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3469462 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#972587}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!