| commit | 263b575d1d1b30360c9d74eed54d6064d18a7caf | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Mon Feb 21 08:35:55 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Feb 21 08:48:28 2022 |
| tree | 030f8448a22c0763abfc608d3aa59e39bbd01b90 | |
| parent | f928d8282c6ed30f215bd3c3b93ebf7a176853ea [diff] |
Pre-paint: Update first-for-node state at fragmentainers.
A nested multicol container may have a padding so tall that there won't
be room for any columns until we get to the next outer column. An
out-of-flow positioned descendant that is *not* contained by the
innermost multicol container needs to be visited exactly once. We missed
the OOF, because is_parent_first_for_node in PrePaintTreeWalk::
WalkLayoutObjectChildren() was wrong. It was set by the inner multicol
container, but the first fragment of the inner multicol container is one
without columns (just padding there), and OOFs are only discovered when
walking inside columns.
Box (block-flow-root block-flow) #outer
Box (column block-flow)
Box (block-flow-root block-flow) #inner
Box (column block-flow)
Box (block-flow-root block-flow) #inner
Box (column block-flow)
Therefore, update is_parent_first_for_node for each column as well.
WalkFragmentationContextRootChildren() already did quite a few things to
the PrePaintTreeWalkContext object passed, which we'd have to reset when
entering non-fragmentainer children (such as column spanners). This
would be one more thing to reset. Instead of this mess, establish a new
PrePaintTreeWalkContext for each column. (It also looks like we had
forgotten to reset fragmentation_nesting_level when entering spanners.)
This also allows us to add some constness to the PrePaintTreeWalkContext
argument.
Bug: 1295998
Change-Id: I8c471936be9c05a6475a4c135bfa7490ac7b09a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468548
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#973450}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!