| commit | 6250e992ac750edc5994a0712fdb6e6f6636ffe3 | [log] [tgz] |
|---|---|---|
| author | Anders Hartvoll Ruud <andruud@chromium.org> | Mon Mar 14 13:36:44 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Mar 14 13:59:39 2022 |
| tree | 91714ffea97e244ac35eda984b7777eadd496cf8 | |
| parent | 63d2655ecd0943f0fa018e1be6ddb2643b9b0253 [diff] |
[@container] Make UpdateStyleAndLayoutTreeForNode understand CQ We currently have pretty serious bugs in getComputedStyle (and similar APIs that force style), since NeedsLayoutTreeUpdateForNodeIncluding- DisplayLocked is completely unaware of container queries: if nothing is *style dirty* in the ancestor chain, we will early-out from UpdateStyleAndLayoutTreeForNode, and never actually update anything. However, for container queries, we have to also check for layout- dirtiness, since doing that layout can affect container-query- dependent elements. This CL tries to formalize the concept of a "layout upgrade", which is a name for when UpdateStyleAndLayoutTree needs to also call UpdateStyleAndLayout due layout dependencies. - NeedsLayoutTreeUpdateForNodeIncludingDisplayLocked needs to return true whenever we *may* need to upgrade. Otherwise we'll early-out, and never even get the chance to upgrade. Hence, we look at the target node and the ancestor chain, and try to figure out if a layout upgrade *will* be needed. We can not know this for sure at this time, because the subsequent call to update style may (for example) remove all container-query containers, i.e. remove layout dependencies. - UpdateStyleAndLayoutTree now accepts a LayoutUpgrade object, which decides how or if an upgrade should take place. NodeLayoutUpgrade being the most interesting of these objects. - NodeLayoutUpgrade::ShouldUpgrade does a second traversal of the ancestor chain to understand if an upgrade is needed. It is not possible to answer this question in the first traversal definitively, since style (first pass) has not been updated yet at that time. For forced updates which target nodes in display:none (or elements without ComputedStyle in general), we can not tell ahead-of-time whether or not something may require an upgrade, since the DependsOnContainerQueries exists on ComputedStyle. Hence, for those situations we defensively assume that we require an upgrade if we're inside an interleaving root [1]. Pseudo-elements also needed adjustment in this CL (the change in ElementRuleCollector). getComputedStyle will call NeedsLayoutTree- UpdateForNodeIncludingDisplayLocked with the originating element, so it is not enough to mark the pseudo-style with as DependsOnContainerQueries, since we never actually observe that style in NeedsLayoutTreeUpdateForNode(etc). Hence we mark the originating element as well, although this will cause some over-invalidation in some cases. (It's possible to iterate on this if needed). [1] Interleaving root = basically a container-for-container-queries that is not display:none. Fixed: 1295717 Change-Id: I2c7d3a82dd513b618ad5245df9b3b6cd7e306d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3472067 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#980529}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!