| commit | 4e9035fad8bcac85717069a50ab8be5e69a5cadd | [log] [tgz] |
|---|---|---|
| author | Javier Fernández García-Boente <jfernandez@igalia.com> | Thu Apr 14 01:05:09 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Apr 14 01:18:26 2022 |
| tree | 630143ff7291aefe5aafc4916859583e29a0f256 | |
| parent | 10fe1d1978aab3b84f9c1167a786a039d1899f94 [diff] |
Throw exception based on exclusions when creating sanitized cookies When we get a nullptr cookie from ToCanonicalCookie we assume that there is an exception to explain the failure. We have a DCHECK to verify such scenario. However, we only generate assertions if there is any problem with the cookie url. The CreateSanitizedCookie function, called to generate the return value with the canonical cookie, performs some additional checks before parsing the cookie string. Any error is described in as exclusion in the CookieInclusionStatus instance. If the status has any exclusion, a nullptr cookie is returned, but no exception is generated. The bug 1315053 describes a scenario where we get a nullotr cookie without an exception, violating the previously mentioned DCHECK. This change fixes the bug by generating exceptions based on the exclusions comment if the CreateSanitizedCookie adds any on the status instance. This change makes our implementation spec complaint, according to what is stated in the CookieStore-set method [1] algorithm: "2- If r is failure, then reject p with a TypeError and abort these steps." [1] https://wicg.github.io/cookie-store/#CookieStore-set Bug: 1315053 Change-Id: I0ebbf727f7404391b12446a457247c4468754015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3582579 Reviewed-by: Ayu Ishii <ayui@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/main@{#992339}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!