| commit | 74372e46d092e81c5b9810ca1c0fd04f20cdb2bd | [log] [tgz] |
|---|---|---|
| author | Bruce Dawson <brucedawson@chromium.org> | Thu May 05 18:57:34 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu May 05 19:04:53 2022 |
| tree | e94c3a1e4f710e685d0b069d4110ef2922b101b3 | |
| parent | bfe011aa848f680dc28a4c353bd51e08caffb757 [diff] |
Fix all .gitignore related WPTLint errors
After rolling WPTLint with this fix:
https://github.com/web-platform-tests/wpt/pull/33697
the WPTLint checks started reporting on long-standing .gitignore issues.
These were:
.gitignore found outside the root (GITIGNORE)
cors/resources/.gitignore
css/.gitignore
css/css-writing-modes/tools/generators/.gitignore
resources/.gitignore
webaudio/.gitignore
matches an ignore filter in .gitignore (IGNORED PATH)
content-security-policy/support/manifest.json
payment-handler/manifest.json
resource-timing/resources/manifest.json
testharness_runner.html
The .gitignore files in child directories were handled with entries in
lint.ignore. The manifest.json IGNORED_PATH errors were because of a
MANIFEST.json entry in the root-level .gitignore file - on Windows that
also matches manifest.json. Adding a leading slash fixed that.
Finally, testharness_runner.html has been checked in since at least 2016
but has a .gitignore entry specifically for it. The .gitignore entry
and the file both seem to be unnecessary so I deleted both of them.
That .gitignore entry was last modified in 2019 (crrev.com/c/1527876)
which presumably only happened because the .gitignore linting was
broken at that time.
With this change the following command now runs clean:
git cl presubmit --files=third_party/blink/web_tests/external/wpt/*
Bug: 1318089
Change-Id: Idf8b45b92b27513a668d1a672ca72600d53b5b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3625631
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1000013}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!